Move processing of recorder service call arguments into services.py#71260
Merged
balloob merged 1 commit intohome-assistant:devfrom May 3, 2022
Merged
Move processing of recorder service call arguments into services.py#71260balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
- Refactoring to prevent queue implementation detail from being accessed outside the recorder
probot-home-assistant
bot
added
code-quality
core
has-tests
integration: recorder
labels
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
bdraco
commented
May 3, 2022
Comment on lines
334
to
339
| def do_adhoc_statistics(self, **kwargs: Any) -> None: | ||
| """Trigger an adhoc statistics run.""" | ||
| if not (start := kwargs.get("start")): | ||
| start = statistics.get_start_time() | ||
| self.queue.put(StatisticsTask(start)) | ||
| self.queue_task(StatisticsTask(start)) | ||
|
|
Member
Author
There was a problem hiding this comment.
We currently only call this in tests. We should probably move this into the the test code instead in a future PR
Member
Author
|
coverage is hitting on the name change only. Adding coverage for these is beyond the scope of this PR. |
balloob
approved these changes
May 3, 2022
Member
Author
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Move processing of recorder service call arguments into
services.pyaccessed outside the recorder
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: